Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ar/2024/2nd #4

Merged
merged 16 commits into from
Jul 11, 2024
Merged

ar/2024/2nd #4

merged 16 commits into from
Jul 11, 2024

Conversation

angeloreale
Copy link
Contributor

@angeloreale angeloreale commented Jul 11, 2024

PLEASE REVIEW YOUR OWN PR BEFORE OPENING/UN-DRAFTING IT

dumping some recently made atoms and molecules

not final designs yet

Have you?

  • Reviewed your own PR?
  • Tested your own feature/fix meets Acceptance Criteria?
  • Made sure it passes all checks? (lint, build, integrations, scripts, etc)?
  • Added unit tests? (if necessary)
  • Added documentation? (if necessary)

If so, THANKS! You can pop a beer/soda.

Please open your PR and ping your colleagues to review it on #web-devs channel.

Also, make sure to remind them on a daily basis during stand-up.

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oneiros ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 8:48pm

@angeloreale
Copy link
Contributor Author

No, I did not review this PR, because I made all of this, and reviewed each PR that came to this point, except these latest commits changing colors and stuff so it's not exactly the same as this other project I've allowed them to use Nexus stuff commercially.

@angeloreale
Copy link
Contributor Author

merging without other approver

@angeloreale angeloreale merged commit 21d9778 into main Jul 11, 2024
5 checks passed
@angeloreale angeloreale deleted the ar/2024/2nd branch July 11, 2024 20:48
Copy link

Rebase with latest work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant